Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update Next.js to 14.0.4 in examples #730

Merged
merged 3 commits into from
Dec 19, 2023
Merged

Conversation

amannn
Copy link
Owner

@amannn amannn commented Dec 19, 2023

No description provided.

Copy link

vercel bot commented Dec 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
next-intl-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2023 10:39am
next-intl-example-app-router ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2023 10:39am

@amannn amannn marked this pull request as ready for review December 19, 2023 10:37
@amannn amannn merged commit 1b51799 into main Dec 19, 2023
3 checks passed
@amannn amannn deleted the chore/upgrade-next-14-0-3 branch December 19, 2023 10:54
@@ -10,7 +10,7 @@
"start": "next start"
},
"dependencies": {
"next": "^14.0.3",
"next": "^14.0.4",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't this be better for examples?

Suggested change
"next": "^14.0.4",
"next": "latest",

It's used in next.js examples

https://github.com/vercel/next.js/blob/c4adae89b17a6f64cc0abe8e697a88b9e1df1814/examples/api-routes/package.json#L9

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Ahmed! I think it's a good idea to pin the major version of Next.js so we can upgrade in a controlled fashion in case breaking changes are introduced.

juanforlizzi pushed a commit to juanforlizzi/next-intl that referenced this pull request Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants